search

inducer / arraycontext

Choose your favorite numpy-workalike!
6 stars 11 forks source link

Force device scalars on PyOpenCLArrayContext #43

Closed alexfikl closed 3 years ago

alexfikl commented 3 years ago

Added a flag with a deprecated default value as suggested in #40.

Fixes #40.

alexfikl commented 3 years ago

Not quite sure how to add the force_device_scalars=True case to the tests as well. Any suggestions?

EDIT: Added a pytest.mark.parametrize and a flag to actx_factory for that, just to make sure it works, but it probably needs something nicer.

alexfikl commented 3 years ago

@inducer This should be ready for another review round.

inducer commented 3 years ago

Looks great! Thanks for getting to this so quickly.