search

inducer / grudge

Grand Unified Discontinuous Galerkin Environment? A DG code in training.
12 stars 17 forks source link

discretization: use part_id instead of removed part_nr #332

Closed alexfikl closed 6 months ago

alexfikl commented 6 months ago

Missed this when working on inducer/meshmode#396.

inducer commented 6 months ago

Thx!

inducer commented 6 months ago

Out of curiosity: how come the downstream test didn't flag this?

alexfikl commented 6 months ago

Out of curiosity: how come the downstream test didn't flag this?

Hm, seems to be in distributed_boundary_swap_connection.. Does the upstream run not use MPI?

EDIT: Grepped a bit and it seems like it should be called, so no idea..

inducer commented 6 months ago

MPI gets turned off for downstream: https://github.com/inducer/ci-support/blob/f2a4fff5ebfb7e37b0eb1e40371471d76f084ced/ci-support.sh#L818

inducer commented 6 months ago

So no mystery here. Thanks for looking... I feel like I could've answered that myself. :grimacing: Sorry!