This change set updates acoustic_pulse to have a tensor product elements option.
Currently, when running with tensor product elements --tpe and overintegration --oi, only eager works properly. When run in lazy mode --lazy, then DiscretizationCollection._base_to_geoderiv_connection (called from _geometry_to_quad_if_requested) does not correctly return a quantity on the quadrature discretization.
This problem affects the use of overintegration in mirgecom; seemingly TPE go into processing that is only valid when element groups are affine and simplices. (5b563de steers around the issue for now).
Overintegration appears to negatively affect the convergence rate for TPEs (see 00b6ca4)
This change set updates
acoustic_pulseto have a tensor product elements option.Currently, when running with tensor product elements
--tpeand overintegration--oi, only eager works properly. When run in lazy mode--lazy, thenDiscretizationCollection._base_to_geoderiv_connection(called from_geometry_to_quad_if_requested) does not correctly return a quantity on the quadrature discretization.works:
python acoustic_pulse.py --tpeworks:python acoustic_pulse.py --tpe --oifails:python acoustic_pulse.py --tpe --oi --lazyThis problem affects the use of overintegration in mirgecom; seemingly TPE go into processing that is only valid when element groups are affine and simplices. (5b563de steers around the issue for now).
Overintegration appears to negatively affect the convergence rate for TPEs (see 00b6ca4)
CC: @inducer