search

inducer / islpy

Python wrapper for isl, an integer set library
http://pypi.python.org/pypi/islpy
73 stars 19 forks source link

work around nominsize issue #121

Closed matthiasdiener closed 1 year ago

matthiasdiener commented 1 year ago

Fixes #120.

Unfortunately, this reduces performance substantially for the microbenchmark (M1): - Without this PR: 42s - With this PR: 56s

With the workaround in https://github.com/inducer/islpy/pull/121/commits/eb62cde751be3519e1069b04a69908ea8cb61963, performance remains the same as before.

This effectively disables the inline implementations of the strtoimax, strtoumax, wcstoimax and wcstoumax functions, which were removed completely in later glibc versions (2.33, https://github.com/bminor/glibc/commit/e182654151a0f6ebbe628c8f2f6b041c69adbac1).

Please squash.

matthiasdiener commented 1 year ago

This is ready for review @inducer.

francesco-ballarin commented 1 year ago

Thanks @matthiasdiener, I confirm that this fixes issue #120 on the docker image I reported there. It would be great if a new patch release could be uploaded to pypi once this PR is merged.

inducer commented 1 year ago

Thx!

inducer commented 1 year ago

2023.2.3. should be finding its way to the package index in a few hours.