inducer / meshmode

High-order unstructured mesh representation and discrete function spaces
https://documen.tician.de/meshmode/
25 stars 24 forks source link

Add tags for all Vandermonde matrix axes #373

Closed majosm closed 1 year ago

majosm commented 1 year ago

Fix/workaround for #372.

inducer commented 1 year ago

LGTM, thanks!

inducer commented 1 year ago

@matthiasdiener Should the mirgecom failures hold up a merge here? Not quite sure what to make of them, they look related to https://github.com/conda-forge/gmsh-feedstock/pull/72.

matthiasdiener commented 1 year ago

@matthiasdiener Should the mirgecom failures hold up a merge here? Not quite sure what to make of them, they look related to conda-forge/gmsh-feedstock#72.

https://github.com/illinois-ceesd/mirgecom/pull/866 should fix this failure. It seems that prepare_downstream_build() in https://gitlab.tiker.net/inducer/ci-support/raw/main/ci-support.sh does not handle conda-env.yml files without a final newline at the end correctly.