search

inducer / meshmode

High-order unstructured mesh representation and discrete function spaces
https://documen.tician.de/meshmode/
26 stars 23 forks source link

Remove MeshElementGroup deprecations #396

Closed alexfikl closed 7 months ago

alexfikl commented 7 months ago

All of these seem to be at least a year overdue and a quick grep showed that nothing is using them anymore (in main at least).

Inspired by #395. Fixes #224.

alexfikl commented 7 months ago

This enables flake8-isort too, but only fixes the two files that were modified here. I can make another PR that does a python -m isort over everything?

EDIT: Well that clearly doesn't work.. it just complains about all the other files. I'll remove that commit.

inducer commented 7 months ago

I'm all in favor (also of getting the isort done).

alexfikl commented 7 months ago

I'm all in favor (also of getting the isort done).

Got it! This still needs a bit of work apparently, so I'll ping you when it's done.

alexfikl commented 7 months ago

@inducer This seems to be passing now!

The last 3 commits are fairly big, but just move things around due to isort and some cleaning up in the firedrake tests (it now uses actx_factory!), so probably better to look at just 4e71cfa.

alexfikl commented 7 months ago

@inducer Re-added the missing note, so this should be ok now!

inducer commented 7 months ago

Thanks!