Closed alexfikl closed 1 month ago
@inducer From what I can tell, the failed test is due to the fact that the mesh isn't checked on replace
, i.e.
Mesh(...)
would run the checks and calling mesh.copy(...)
would also run the checks.make_mesh(...)
runs the checks, but running replace(mesh, ...)
does not run the checks. (this makes sense to me)Does that mean that every Mesh.copy
should be replaced with a replace + assert is_mesh_consistent(...)
?
EDIT: https://github.com/inducer/meshmode/compare/405a6bf3c3f11460420b702a6c6bcb8c895d060d..9ec01ac324deb4237ef0128e9c5159596f55f9b0 should hopefully fix the failed test.
Thx!
There's still a bunch of warnings about SVM memory like
and some more loopy warnings, but everything else should be clean.