inducer / meshmode

High-order unstructured mesh representation and discrete function spaces
https://documen.tician.de/meshmode/
25 stars 24 forks source link

Fix warnings and deprecations #408

Closed alexfikl closed 1 month ago

alexfikl commented 2 months ago

There's still a bunch of warnings about SVM memory like

<generated code for 'invoke_frozen_nodes1_2d_loopy_kernel'>:131: InconsistentOpenCLQueueWarning: Array has different queue from backing SVM memory. This may lead to the array getting deallocated sooner than expected, potentially leading to crashes.

and some more loopy warnings, but everything else should be clean.

alexfikl commented 2 months ago

@inducer From what I can tell, the failed test is due to the fact that the mesh isn't checked on replace, i.e.

Does that mean that every Mesh.copy should be replaced with a replace + assert is_mesh_consistent(...)?

EDIT: https://github.com/inducer/meshmode/compare/405a6bf3c3f11460420b702a6c6bcb8c895d060d..9ec01ac324deb4237ef0128e9c5159596f55f9b0 should hopefully fix the failed test.

inducer commented 1 month ago

Thx!