search

inducer / meshmode

High-order unstructured mesh representation and discrete function spaces
https://documen.tician.de/meshmode/
26 stars 23 forks source link

Remove `TensorProductElementGroupBase.bases_1d` #409

Closed inducer closed 5 months ago

inducer commented 5 months ago

To get the tests in https://github.com/inducer/grudge/pull/338 to go, zero-dimensional tensor product discretizations need to work. This bases_1d thing (which seems kind of ill-defined anyway) was an obstacle. It appeared entirely unused across meshmode and grudge.

@a-alveyblanc Do you have any objections to this?

a-alveyblanc commented 5 months ago

This is necessary to get the 1D basis (bases) used to build the TP basis so that we can retrieve 1D operators.

inducer/grudge#313 depends on bases_1d for fast operator evaluation to work

(sorry if formatting is bad, I'm replying on GH mobile)

EDIT: From what I can tell by the changes, this can be worked around in inducer/grudge#313. Seems fine to merge.

inducer commented 5 months ago

OK, thanks!