search

inducer / pudb

Full-screen console debugger for Python
https://documen.tician.de/pudb/
Other
3k stars 230 forks source link

Make sure we can actually look up the values for keys to containers in the variable view #412

Closed mvanderkamp closed 3 years ago

mvanderkamp commented 4 years ago

Defining keys() but not getitem is a pretty big code smell, but that doesn't mean we should crash.

mvanderkamp commented 3 years ago

I think that should work. I was thinking of adding unit tests for the walk_value method to make sure that all these various edge cases are handled and continue to behave reasonably, but I might do that separately unless you think that it would be a good thing to add here.

inducer commented 3 years ago

I was thinking of adding unit tests for the walk_value method to make sure that all these various edge cases are handled and continue to behave reasonably, but I might do that separately unless you think that it would be a good thing to add here.

I like this idea. Thanks for offering to add that.