inducer / pudb

Full-screen console debugger for Python
https://documen.tician.de/pudb/
Other
3k stars 230 forks source link

ptpython now use ~/.local/share/ptpython/history instead of ~/.ptpython/history #426

Closed sisrfeng closed 2 years ago

sisrfeng commented 3 years ago

should this linein pudb/shell.py be changed? history_filename = os.path.expanduser("~/.local/share/ptpython/history")

inducer commented 3 years ago

PRs welcome.

asmeurer commented 3 years ago

If the idea is to reuse the same history file as ptpython itself, why pass it in at all? Won't it default to the right thing?

IMO shells should use separate history files, so something like

    hist_file = join(
            get_save_config_path(),
            "ptpython-shell-history")

would be better (but I don't use the ptpython shell so I don't feel strongly about this).