Closed Freed-Wu closed 2 years ago
It looks like much of the diff here consists of spurious white space changes from code reformatting, making it harder to review than necessary. Please refrain from making such changes, and undo the ones you've made. Thanks!
Also, see the linter failures here.
OK. All checks have passed.
This is nice. Thanks!
Support more shells by shtab
The disadvantage is importing a new dependency. However, shtab can support more shells (bash/zsh/tcsh, and fish/posh in plan), and it can provide an option
--print-completion
for user and packager to generate shell completion and for developer to test, so I think it may be acceptable.I have tested bash/zsh can work. (I don't have installed tcsh)
BTW, shtab has a bug for zsh, that is pudb3 has script_args which nargs is argparse.REMINDER, but shtab cannot support. I temporarily fix it in my fork and send a PR to shtab.
This is a version after fixing. You can put it directed to the correct directory.
Result:
The test failed. However, I haven't change
pudb/var_view.py
. What happened?