search

inducer / pudb

Full-screen console debugger for Python
https://documen.tician.de/pudb/
Other
2.94k stars 226 forks source link

Fix separate-terminal debugging #656

Closed MatrixManAtYrService closed 1 month ago

MatrixManAtYrService commented 1 month ago

This PR reverts part of https://github.com/inducer/pudb/pull/534, which appears to have broken the ability to debug in a separate terminal (see comment there for more).

Presumably there was a reason that we wanted to close this file, but I'm not sure what that reason was. Leaving it open restored this functionality for me and nothing else bad appears to be happening 🤷 .

Maybe @inducer can suggest a better place for closing the file so that the needs of https://github.com/inducer/pudb/pull/534 are met while also not breaking separate-terminal debugging?

MatrixManAtYrService commented 1 month ago

Fixes https://github.com/inducer/pudb/issues/598

MatrixManAtYrService commented 1 month ago

I just realized there's already one for this: https://github.com/inducer/pudb/pull/638. Seems like the challenge there had to do with ensuring that the tty file is eventually closed. I'll take a crack at it...

inducer commented 1 month ago

This looks good to me; thanks for working on it. I'll roll a release to get this out into the world.

inducer commented 1 month ago

Ah! Just noticed that you've reverted this to draft; how come?

MatrixManAtYrService commented 1 month ago

Sorry for being indecisive. I had a problem which I thought might be introduced by this change, so I got paranoid and marked it as a draft with the idea that I'd use it for a while before calling it good. As it turns out, that problem was entirely separate.

I used it for a while, and that worked well, but then I forgot to circle back and un-draft it. I'll do that now.

inducer commented 1 month ago

Thanks!

inducer commented 1 month ago

https://pypi.org/project/pudb/2024.1.2/