search

inducer / pymbolic

A simple package to do symbolic math (focus on code gen and DSLs)
http://mathema.tician.de/software/pymbolic
Other
106 stars 24 forks source link

Test missing assertions #129

Open iandinwoodie opened 1 year ago

iandinwoodie commented 1 year ago

The following test doesn't seem to be making any assertions about expected behavior:

https://github.com/inducer/pymbolic/blob/13e83df783d00a74b0d13d690f8f96d806646e13/test/test_pymbolic.py#L85-L94

iandinwoodie commented 1 year ago

Similarly, the following test seems to log a response but not make any assertions about it:

https://github.com/inducer/pymbolic/blob/13e83df783d00a74b0d13d690f8f96d806646e13/test/test_pymbolic.py#L372-L385

inducer commented 1 year ago

Thanks for reporting these. Contributions to address these would be very welcome.

iandinwoodie commented 1 year ago

@inducer will do!