Closed isuruf closed 2 years ago
LGTM. Thanks!
Thanks
@isuruf Could you remind me why we did this? Shouldn't getattr
find attributes from anywhere in the MRO? (I touched this code in #110 and was wondering. We should probably add a comment.)
I guess if the mapper implementation contains a mapper method for the superclass but not the derived class, then this should come in handy.
Ah right. Somehow I was thinking of the MRO of the mapper, but this is the MRO of the expression node. Nvm, all good.
First pymbolic will look for mapper_method given by the object and if not found, look for mapper_method class attributes in the object's method resolution order