search

inducer / pyopencl

OpenCL integration for Python, plus shiny features
http://mathema.tician.de/software/pyopencl
Other
1.05k stars 240 forks source link

Fix pocl version parsing #563

Closed inducer closed 2 years ago

inducer commented 2 years ago

Without this fix, PyOpenCL dies on pocl versions 3.0pre and newer with

Traceback (most recent call last):                                                                                                                                                                                                              
  File "/home/andreas/src/pyopencl/test/test_algorithm.py", line 52, in test_elwise_kernel                                                                                                                                                      
    a_gpu = clrand(queue, (50,), np.float32)                                                                                                                                                                                                    
  File "/home/andreas/src/pyopencl/pyopencl/clrandom.py", line 767, in rand                                                                                                                                                                     
    gen.fill_uniform(result, a=a, b=b)                                                                                                                                                                                                          
  File "/home/andreas/src/pyopencl/pyopencl/clrandom.py", line 681, in fill_uniform                                                                                                                                                             
    return self._fill("uniform", ary,                                                                                                                                                                                                           
  File "/home/andreas/src/pyopencl/pyopencl/clrandom.py", line 658, in _fill                                                                                                                                                                    
    self.get_gen_kernel(ary.dtype, distribution)                                                                                                                                                                                                
  File "/home/andreas/src/pytools/pytools/__init__.py", line 755, in wrapper                                                                                                                                                                    
    result = function(obj, *args, **kwargs)                                                                                                                                                                                                     
  File "/home/andreas/src/pyopencl/pyopencl/clrandom.py", line 640, in get_gen_kernel                                                                                                                                                           
    knl = getattr(prg, kernel_name)                                                                                                                                                                                                             
  File "/home/andreas/src/pyopencl/pyopencl/__init__.py", line 461, in __getattr__                                                                                                                                                              
    knl = Kernel(self, attr)                                                                                                                                                                                                                    
  File "/home/andreas/src/pyopencl/pyopencl/__init__.py", line 817, in kernel_init                                                                                                                                                              
    self._setup(prg)                                                                                                                                                                                                                            
  File "/home/andreas/src/pyopencl/pyopencl/__init__.py", line 823, in kernel__setup                                                                                                                                                            
    self._enqueue, self._set_args = generate_enqueue_and_set_args(                                                                                                                                                                              
  File "/home/andreas/src/pyopencl/pyopencl/invoker.py", line 384, in generate_enqueue_and_set_args                                                                                                                                             
    _check_arg_size(function_name, num_cl_args, arg_types, devs)                                                                                                                                                                                
  File "/home/andreas/src/pyopencl/pyopencl/invoker.py", line 336, in _check_arg_size                                                                                                                                                           
    dev_limit = _get_max_parameter_size(dev)                                                                                                                                                                                                    
  File "/home/andreas/src/pyopencl/pyopencl/invoker.py", line 317, in _get_max_parameter_size                                                                                                                                                   
    if get_pocl_version(dev.platform) is not None:                                                                                                                                                                                              
  File "/home/andreas/src/pyopencl/pyopencl/characterize/__init__.py", line 336, in get_pocl_version                                                                                                                                            
    raise ValueError(msg)                                                                                                                                                                                                                       
ValueError: pocl version number did not have expected format: 'OpenCL 3.0 PoCL 1.9-pre tags/v3.0-RC1-0-g72b4fe4  Linux, Release, RELOC, SPIR, LLVM 14.0.3, SLEEF, POCL_DEBUG'
inducer commented 2 years ago

Given how critical an issue this is (nothing runs on newer pocls), I'll roll a release after this is in.

inducer commented 2 years ago

https://github.com/inducer/pyopencl/releases/tag/v2022.1.5