search

inducer / pyopencl

OpenCL integration for Python, plus shiny features
http://mathema.tician.de/software/pyopencl
Other
1.05k stars 240 forks source link

Implement dedicated kernels for `{min,max}imum` #592

Closed inducer closed 2 years ago

inducer commented 2 years ago

@majosm Turns out #584 mishandled infinities, which are used frequently as neutral elements. @matthiasdiener This may be behind the NaNs that we were seeing, i.e. unrelated to the memory pool.

matthiasdiener commented 2 years ago

@matthiasdiener This may be behind the NaNs that we were seeing, i.e. unrelated to the memory pool.

Yes, this PR does fix the NaNs we are seeing.

inducer commented 2 years ago

Force-merging since earlier tests passed and the latest changes only affected the (project-local) tests, which have passed.