inducer / pyopencl

OpenCL integration for Python, plus shiny features
http://mathema.tician.de/software/pyopencl
Other
1.06k stars 241 forks source link

Windows CI #624

Closed isuruf closed 2 years ago

isuruf commented 2 years ago

There is only one failure. Fails with OUT_OF_HOST_MEMORY

inducer commented 2 years ago

There is only one failure. Fails with OUT_OF_HOST_MEMORY

You could skip or xfail that test on Windows.

inducer commented 2 years ago

Merged https://github.com/inducer/ci-support/pull/23. Could you re-point this at upstream ci-support?

inducer commented 2 years ago

Thanks!

inducer commented 2 years ago

Promptly failed on main: https://github.com/inducer/pyopencl/actions/runs/3192931480/jobs/5210961672#step:3:793

Could you take a look?

isuruf commented 2 years ago

That's a very weird error. I have no idea how the strides can ever be different.

_ test_slice[<context factory for <pyopencl.Device 'Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz' on 'Intel(R) OpenCL'>>] _
[gw0] win32 -- Python 3.10.6 D:\a\pyopencl\pyopencl\.miniforge3\envs\testing\python.exe
Traceback (most recent call last):
  File "D:\a\pyopencl\pyopencl\test\test_array.py", line 1150, in test_slice
    a_gpu[start:end] = tp(2)*b[start:end]
  File "D:\a\pyopencl\pyopencl\pyopencl\array.py", line 2291, in __setitem__
    self.setitem(subscript, value)
  File "D:\a\pyopencl\pyopencl\pyopencl\array.py", line 2266, in setitem
    raise NotImplementedError("cannot assign between arrays of "
NotImplementedError: cannot assign between arrays of differing strides
inducer commented 2 years ago

I agree it's weird, but I don't have time to deal with it now. Want me to revert while you investigate?

inducer commented 1 year ago

There might be something wrong with that test. Here's a crash on the Linux side: https://github.com/inducer/pyopencl/actions/runs/3207693960/jobs/5242841641

isuruf commented 1 year ago

Ah I think I know the issue. There are some tests skipped in pyopencl because of zero sized arrays not supported in Intel CL. We can have zero sized arrays in the test at https://github.com/inducer/pyopencl/blob/9e87128cc7907979eb9c3bbeaf765305a8e94004/test/test_array.py#L1141