Closed alexfikl closed 1 year ago
Could you explain? It sounds like you're trying to argue that this isn't a compatibility break, but I'm not sure where the ValueError
would have come from.
This chunk seems to handle the kwargs
and wait_for
isn't allowed, so there's no point for it to do be in the dataclass.
https://github.com/inducer/pyopencl/blob/9e87128cc7907979eb9c3bbeaf765305a8e94004/pyopencl/array.py#L2473-L2484
Thanks! Got it, in it goes.
As far as I can tell,
arange
would raise aValueError
ifwait_for
was passed in, so this is not needed.