search

inducer / pyopencl

OpenCL integration for Python, plus shiny features
http://mathema.tician.de/software/pyopencl
Other
1.04k stars 239 forks source link

Make sure there are no 0-sized arrays in test_slice #630

Closed isuruf closed 1 year ago

inducer commented 1 year ago

What exactly is causing issues for the Intel ICD here? Empty NDRanges? Zero-size allocations? Both of these are already handled specially...

isuruf commented 1 year ago

Multiplying a zero sized array by a scalar.

inducer commented 1 year ago

Yeah... but what specifically about that is causing issues? Any idea?

isuruf commented 1 year ago

Looks like this error happens in apple implementation too as pointed out by @alexfikl in https://github.com/inducer/pyopencl/pull/616#issuecomment-1279691695

alexfikl commented 1 year ago

Looks like this error happens in apple implementation too as pointed out by @alexfikl in #616 (comment)

Hasn't happened in the last 3 runs though, so not quite sure what to make of that. Is it intermittent on Intel as well?

isuruf commented 1 year ago

Yes, you need end = randrange(start, ary_len) == start for the error to occur.

alexfikl commented 1 year ago

Yes, you need end = randrange(start, ary_len) == start for the error to occur.

Ah, thanks! Missed the random in that test.

inducer commented 1 year ago

Thanks! Superseded by https://github.com/inducer/pyopencl/pull/638.