search

inducer / pyopencl

OpenCL integration for Python, plus shiny features
http://mathema.tician.de/software/pyopencl
Other
1.04k stars 237 forks source link

fix create_some_context doc #732

Closed matthiasdiener closed 2 months ago

matthiasdiener commented 2 months ago

Side question: Is the comment

https://github.com/inducer/pyopencl/pull/732/files#diff-c92a2dfd89b4e37e39a4e9664d9a0f65e5a9a332c741e429c225b69f8bc15d7aR125-L129

Calling the constructor with no arguments will fail for recent CL drivers that support the OpenCL ICD. If you want similar, just-give-me-a-context-already behavior, we recommend :func:create_some_context. See, e.g. this explanation by AMD <https://web.archive.org/web/20101114195033/https://developer.amd.com/support/KnowledgeBase/Lists/KnowledgeBase/DispForm.aspx?ID=71>__.

still correct?

inducer commented 2 months ago

Side question: Is the comment still correct?

Yes, but it's very fundamentally outdated, as no-one uses OpenCL without ICD loaders any more.

matthiasdiener commented 2 months ago

Side question: Is the comment still correct?

Yes, but it's very fundamentally outdated, as no-one uses OpenCL without ICD loaders any more.

I reworded this slightly in 43280c2 (but I'm not sure if it's correct).

inducer commented 2 months ago

Thx!