search

inducer / pyopencl

OpenCL integration for Python, plus shiny features
http://mathema.tician.de/software/pyopencl
Other
1.04k stars 237 forks source link

Fix pooled_buffer.release() #751

Closed matthiasdiener closed 1 month ago

matthiasdiener commented 1 month ago

Similar fix as pooled_svm.release().

Without the extra free(), nanobind says:

TypeError: release(): incompatible function arguments. The following argument types are supported:
    1. release(self) -> None

Invoked with types: pyopencl._cl.PooledBuffer

See also https://github.com/illinois-ceesd/mirgecom/actions/runs/8994108270/job/24707084570

matthiasdiener commented 1 month ago

This is ready for review. Any chance of a 2024.2.2 release with this PR (and maybe #750)?

inducer commented 1 month ago

Thanks!

inducer commented 1 month ago

https://github.com/inducer/pyopencl/releases/tag/v2024.2.2 is on the way, should show up on the package index in an hour-ish?

matthiasdiener commented 1 month ago

Wonderful, thank you!