search

inducer / pytato

Lazily evaluated arrays in Python
Other
8 stars 16 forks source link

Eliminate recursive forwarding in mappers #446

Closed majosm closed 11 months ago

majosm commented 11 months ago

@inducer Turns out I didn't revert these changes after all, I just wasn't looking far enough down the commit list. 🙂

(I'll submit the InlinedExpressionGenMapper changes as a separate PR since they're a little less trivial.)

inducer commented 11 months ago

Oh. The failures are my problem. I saw that mirgecom had switched to Mambaforge for installs, and I figured I'd be a copycat. https://github.com/inducer/ci-support/commit/4b868fe4ed49f26bb108c856d94143ab86710f2e Apparently I broke it.

inducer commented 11 months ago

Fixed! Though this matches my recollection--these methods are mainly for mypy's benefit. Maybe you could make them if TYPE_CHECKING?

inducer commented 11 months ago

Thanks!

inducer commented 11 months ago

(I'll wait until you un-draft this.)

majosm commented 11 months ago

(I'll wait until you un-draft this.)

Done!