search

inducer / pytato

Lazily evaluated arrays in Python
Other
8 stars 16 forks source link

Disable bounds checking when no loopy call present #449

Closed matthiasdiener closed 11 months ago

matthiasdiener commented 11 months ago

Alternative to https://github.com/inducer/arraycontext/pull/239.

matthiasdiener commented 11 months ago

Is this what you had in mind @inducer?

inducer commented 11 months ago

Yep, that's spot on. I think this makes sense. I'll wait for you to un-draft.

kaushikcfd commented 11 months ago

Why are we disabling the bounds check only when there's a loopy call. Shouldn't we always disable it?

kaushikcfd commented 11 months ago

Why are we disabling the bounds check only when there's a loopy call. Shouldn't we always disable it?

Aah I think I see it. loopy_call corresponds to user code which needs bounds checking. Sorry for the noise.

matthiasdiener commented 11 months ago

Yep, that's spot on. I think this makes sense. I'll wait for you to un-draft.

Thanks! I've set it to ready for review.

inducer commented 11 months ago

Given @kaushikcfd's question, I think it'd make sense to include a comment to explain the reasoning.

matthiasdiener commented 11 months ago

Given @kaushikcfd's question, I think it'd make sense to include a comment to explain the reasoning.

What do you think of ab38959?

inducer commented 11 months ago

Works for me. Thanks!