search

inducer / pytato

Lazily evaluated arrays in Python
Other
8 stars 16 forks source link

Update to pass *args and **kwargs through #487

Closed nkoskelo closed 3 months ago

nkoskelo commented 4 months ago

When copying an IndexLambda with the CopyMapperAndExtraArgs we do not pass the extra arguments to the dispatcher looking at the subexpressions.

inducer commented 3 months ago

Thanks!

inducer commented 3 months ago

As a comment, when writing commit messages (and PR titles), assume the reader has no context. (i.e. they're looking at the first line of the commit message like an email subject line).

So, instead of "Update to pass *args and **kwargs through", a better message might be "CopyMapperAndExtraArgs: actually pass args for IndexLambda" or so. Similar for the other commit.

Also, strive to include as much information in the commit message, as opposed to the PR description. The latter will be lost to time. (Plus, Github automatically grabs the commit message and uses it as the PR description.)