search

inducer / relate

RELATE is an Environment for Learning And TEaching
http://documen.tician.de/relate
Other
383 stars 118 forks source link

Remove non exist static references. #946

Closed dzhuang closed 2 years ago

dzhuang commented 2 years ago

Since the introduction of django-bootstrap-datepicker-plus, those links were no longer valid.

inducer commented 2 years ago

Thanks! These changes are already part of #892, which I am hoping to merge over the next week or so. As a result, I think I would prefer to merge them via that route. In fact, the only thing that's missing in #892 from my perspective are some rendering issues with the InlineMultiQuestion, specifically the various tooltip and right/wrong indicators. If you are able, it would be super helpful if you could take a look at that since you know that code better than me, and, perhaps, submit a PR targeting the bs5 branch.

dzhuang commented 2 years ago

Thanks. I guess the issue you mentioned is the removal of glyphicons in Bootstrap 5, I'll try to work on that in a few days.

inducer commented 2 years ago

It's not so much the glyphicons, it's all the popup/over/under logic and the field layout which has changed substantially in bs5.

dzhuang commented 2 years ago

This PR is closed in favor of #949.