inducer / starlark-pyo3

A Python wrapper for starlark-rust
Other
16 stars 3 forks source link

Provide wheels for python 3.11 for Windows on pypi #7

Closed vawale closed 1 year ago

vawale commented 1 year ago

Hi,

Can you please upload wheels for python 3.11 Windows on https://pypi.org/project/starlark-pyo3/?

pip install starlark-pyo3 fails on Windows with python 3.11, with following compile error in source:

error: could not compile `gazebo` due to 4 previous errors
      warning: build failed, waiting for other jobs to finish...
      error: could not compile `gazebo` due to 4 previous errors
      💥 maturin failed
        Caused by: Failed to build a native library through cargo
        Caused by: Cargo build finished with "exit code: 101": `"cargo" "rustc" "--release" "--message-format" "json" "--lib"`
      🔗 Found pyo3 bindings
      ðŸ\x90\x8d Found CPython 3.11 at C:\Program Files\Python311\python.exe
      error[E0554]: `#![feature]` may not be used on the stable release channel
        --> C:\Users\vagrant\.cargo\registry\src\github.com-1ecc6299db9ec823\gazebo-0.8.0\src\lib.rs:10:49
         |
      10 | #![cfg_attr(feature = "str_pattern_extensions", feature(pattern))]
         |                                                 ^^^^^^^^^^^^^^^^
...
Error: command ['maturin', 'pep517', 'build-wheel', '-i', 'C:\\Program Files\\Python311\\python.exe', '--compatibility', 'off'] returned non-zero exit status 1
      [end of output]
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for starlark-pyo3
Failed to build starlark-pyo3
ERROR: Could not build wheels for starlark-pyo3, which is required to install pyproject.toml-based projects

Trying to use rust nightly toolchain: rustup run nightly pip install starlark-pyo3 results in following error:

error: could not compile `starlark` (lib) due to 190 previous errors
      💥 maturin failed
        Caused by: Failed to build a native library through cargo
        Caused by: Cargo build finished with "exit code: 101": `"cargo" "rustc" "--release" "--message-format" "json" "--lib"`
      🔗 Found pyo3 bindings
      ðŸ\x90\x8d Found CPython 3.11 at C:\Program Files\Python311\python.exe
      error[E0557]: feature has been removed
         --> C:\Users\vagrant\.cargo\git\checkouts\starlark-rust-59575ffdf833204c\e1f8794\starlark\src\lib.rs:354:12
          |
      354 | #![feature(box_syntax)]
          |            ^^^^^^^^^^ feature has been removed
          |
          = note: replaced with `#[rustc_box]`

I was able to build the wheel for python 3.11 by cloning the repo and running: rustup run nightly maturin pep517 build-wheel --compatibility off

inducer commented 1 year ago

3.11 Windows wheels should now be available.

vawale commented 1 year ago

Thanks :smile: