search

inducer / sumpy

Symbolic code generators for multipole and local expansions and translations
32 stars 13 forks source link

Pass all arguments to CSE constructor #188

Closed alexfikl closed 1 year ago

alexfikl commented 1 year ago

Was playing with adding __slots__ to pymbolic expressions on the attrs branch. That doesn't work with default arguments, since it considers them class attributes and dataclass gets confused.

Very few expressions had that issue though, mostly just CommonSubexpression and NaN, and this fixes it here if we ever want to try it!

inducer commented 1 year ago

(I know you meant these as just-in-case, but IMO there's no real downside to merging them.)