search

inductiveautomation / ignition-module-tools

Tools that help in the creation and development of Modules for Inductive Automation's Ignition.
49 stars 14 forks source link

Support lazy evaluation of signed module output file #51

Closed benmusson closed 3 months ago

benmusson commented 3 months ago

This change converts .map/.get to .flatMap to allow for lazier evaluation of the signed module output file.

brianeray commented 3 months ago

I think this is implicitly tested by existing coverage in SignModuleTest, but need to loop back around on Monday to be sure.

brianeray commented 3 months ago

OK, finally getting to this today. One thing is that since you are coding in your own master fork it's prone to echoes in the commit history, ie commit 81e986e in the current PR. This needs to be rebased on the upstream inductiveautomation/ignition-module-tools master to remove that from the PR and leave only the commit(s) fixing the issue.

Spinning up another branch in your fork to replace this PR might be easier, but up to you.

Either way I'm kicking the tires on this commit locally. Should be able to wrap up this (or a replacement) PR today. 🤞

benmusson commented 3 months ago

One thing is that since you are coding in your own master fork it's prone to echoes in the commit history, ie commit 81e986e in the current PR.

Yup, that is kinda gross. Will fix today.

brianeray commented 3 months ago

I try to tread lightly on suggestions on cleaning up commit history because I don't know how much expertise any particular contributor has with Git itself. Much of its functionality is not obvious and getting clean commit history can be even less obvious. E.g. when to use merge vs pull vs rebase vs cherry-pick vs whatever. They all smoosh code from two branches together.

benmusson commented 3 months ago

@brianeray Eh, I think it's good to be picky 😉 https://github.com/inductiveautomation/ignition-module-tools/pull/55