IGN-10612 WIP refactor jar entry deduplication

inductiveautomation / ignition-module-tools

Tools that help in the creation and development of Modules for Inductive Automation's Ignition.

49 stars 14 forks source link

Closed brianeray closed 3 months ago

brianeray commented 3 months ago

Do not merge. Just for sharing code.

A stab at "code golf" and clarifying some existing and some new code from #53. So maybe it's code golf + code ping pong.

See my diff comments for reasoning.

brianeray commented 3 months ago

Just to link all the things: #52.

benmusson commented 3 months ago

Looks good! It was a good idea to add some tests with transitive dependencies. My only suggestion is contained in https://github.com/brianeray/ignition-module-tools/pull/1.

brianeray commented 3 months ago

Shutting this down since it's a Draft, just a code sharing mechanism.