industrydive / fileflow

Airflow plugin to transfer arbitrary files between operators
http://fileflow.readthedocs.io/en/latest/
Apache License 2.0
78 stars 21 forks source link

Make pip understand the version set for fileflow #7

Closed lauralorenz closed 7 years ago

lauralorenz commented 7 years ago

Something is wrong with the version number when trying to install fileflow in that it thinks its 0.0.0 even though our setup.cfg, at time of writing, sets it to 0.0.3. Not sure if this is a property of the git install and/or if this will cause problems with later installs since we're installing from commit hashes, but I think worth figuring out including how it may interact with PyPI packages.

(fileflow)~ $ pip freeze | grep fileflow
You are using pip version 6.0.8, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
fileflow==0.0.0
ksindi commented 7 years ago

Awesome project. For easier version management, I recommend using setuptools_scm, which allows you to use your git / mercurial tags for versioning.

lauralorenz commented 7 years ago

@ksindi great suggestion, we will check it out

lauralorenz commented 7 years ago

This was fixed by https://github.com/industrydive/fileflow/pull/11.