Closed felix closed 8 years ago
Nice! Does it work? ;)
It seems to ;-) I have not looked at all the schemas and have only added a test for a string type. May have time to look at it in the next couple of days.
Ok, it would be great to test more of these for sure :) Thanks!
@felix ping ;)
@indutny I have not forgotten about this. Project usage will force me to write tests for it soon.
@indutny I have fleshed out the schemas and RFC 3280's tests work with 5280. The extension parsing tests could be expanded more when time permits.
@indutny anything more to get this merged?
Sorry for delay @felix ! Left some comments, thank you!
@indutny cleaned it all up a little except for the blob files, your call on that one.
Looks cool, almost ready to land. Let's move the blobs to fixtures dir, move existing 3280 tests to 5280 tests, and remove 3280 module. Should be good to go after that!
Thank you!
Ping @indutny, anything more?
@felix there is no github notifications when you push more commits to PR (please make sure to ping me if you want me to take a look). I will take a look at this PR tomorrow!
Thank you!
Landed and published, thank you!
Resurrecting and completing an old pull request by chjj.