search

indutny / asn1.js

ASN.1 Decoder/Encoder/DSL
MIT License
181 stars 64 forks source link

rfc5280 #47

Closed felix closed 8 years ago

felix commented 9 years ago

Resurrecting and completing an old pull request by chjj.

indutny commented 9 years ago

Nice! Does it work? ;)

felix commented 9 years ago

It seems to ;-) I have not looked at all the schemas and have only added a test for a string type. May have time to look at it in the next couple of days.

indutny commented 9 years ago

Ok, it would be great to test more of these for sure :) Thanks!

indutny commented 9 years ago

@felix ping ;)

felix commented 9 years ago

@indutny I have not forgotten about this. Project usage will force me to write tests for it soon.

felix commented 8 years ago

@indutny I have fleshed out the schemas and RFC 3280's tests work with 5280. The extension parsing tests could be expanded more when time permits.

felix commented 8 years ago

@indutny anything more to get this merged?

indutny commented 8 years ago

Sorry for delay @felix ! Left some comments, thank you!

felix commented 8 years ago

@indutny cleaned it all up a little except for the blob files, your call on that one.

indutny commented 8 years ago

Looks cool, almost ready to land. Let's move the blobs to fixtures dir, move existing 3280 tests to 5280 tests, and remove 3280 module. Should be good to go after that!

indutny commented 8 years ago

Thank you!

felix commented 8 years ago

Ping @indutny, anything more?

indutny commented 8 years ago

@felix there is no github notifications when you push more commits to PR (please make sure to ping me if you want me to take a look). I will take a look at this PR tomorrow!

indutny commented 8 years ago

Thank you!

indutny commented 8 years ago

Landed and published, thank you!