search

indutny / asn1.js

ASN.1 Decoder/Encoder/DSL
MIT License
184 stars 64 forks source link

Removed all cyclic dependencies. #50

Closed originalgremlin closed 7 years ago

originalgremlin commented 9 years ago

Same story as in indutny/elliptic: In my attempts to include this code in a React Native project I discovered a number of cyclic dependencies that prevented their default packager from completing. With the liberal rewriting of a few requires all the cycles have been eliminated (according to pahen/madge).

These changes are all superficial. All tests continue to pass.

indutny commented 9 years ago

Thanks! But I think we should open an issue at React Native instead.

originalgremlin commented 9 years ago

Opening an issue with the folks at React Native is definitely a good idea.

For now, moving this conversation to https://github.com/indutny/elliptic/pull/55.