search

indutny / asn1.js

ASN.1 Decoder/Encoder/DSL
MIT License
181 stars 64 forks source link

Add stack object to errors when called if needed #72

Closed felix closed 8 years ago

felix commented 8 years ago

Edge (and IE?) only adds a stack object to Error once it is thrown. See https://msdn.microsoft.com/en-us/library/hh699850(v=vs.94).aspx

We were getting strange errors in schema decoding on MS Edge which other browsers dealt with fine. Running this test suite via Karma in a variety of browsers helped to reveal this issue.

felix commented 8 years ago

Thanks @indutny, nicer than my last-minute-fix-before-leaving.

felix commented 8 years ago

Cleaned up some rogue commits in this branch.

indutny commented 8 years ago

@felix thank you so much for PRs! I'll go through them this week. Sorry, been buried with lots of things!

indutny commented 8 years ago

@felix btw, I don't get notifications when you push new commits to PR. If you updated it and want me to take a look - please do not hesitate to ping me in this thread.

indutny commented 8 years ago

Landed and released, thank you!