indutny / asn1.js

ASN.1 Decoder/Encoder/DSL
MIT License
184 stars 64 forks source link

Fix revoked certificate decoding #84

Closed ruiquelhas closed 7 years ago

ruiquelhas commented 7 years ago

Fixes #82. Fixes #83.

I'm adding a test asserting the possible CRL conditions (empty or not-empty list of revoked certificates) alongside the fix.

I've introduced a new definition - RevokedCertificate - which does not have a direct match in RFC 5280, thus is not being exposed in the API.

I've extracted the CRL from a couple of fixture certificate files (available through distribution points) which I'm using in the test.

indutny commented 7 years ago

Both landed with very minor fixes. Excellent patch, thank you!

indutny commented 7 years ago

Released in asn1.js-rfc5280@1.2.2.