indutny / bn.js

BigNum in pure javascript
MIT License
1.2k stars 151 forks source link

Fix BN v5/v4 interoperability issue for 5.x #247

Closed holgerd77 closed 4 years ago

holgerd77 commented 4 years ago

Fixes #239 on the 5.x branch

Made sure that the respective code part is actually touched by the unit tests.

holgerd77 commented 4 years ago

Uh. What happened here? 🤔

holgerd77 commented 4 years ago

Can you re-trigger CI here?

holgerd77 commented 4 years ago

Wait, I'll just submit a new PR, maybe that helps.

fanatid commented 4 years ago

I re-trigger CI manually, but was cancelled again. Can you try make amend commit and make force push? Maybe this help?

holgerd77 commented 4 years ago

Will close for a second try in favor of #249 due to Ci problems.