search

indutny / bn.js

BigNum in pure javascript
MIT License
1.19k stars 150 forks source link

Fix BN v5/v4 interoperability issue for v5.x #249

Closed holgerd77 closed 4 years ago

holgerd77 commented 4 years ago

Fixes #239 on the 5.x branch

Made sure that the respective code part is actually touched by the unit tests.

(second try following #247 after CI problems)

holgerd77 commented 4 years ago

That's indeed strange. 😕

Maybe just do the fix yourself directly on the main repo, don't have to retain me as the author or something.

holgerd77 commented 4 years ago

Ah no, did another short test (changing the code comments a little), didn't work.

Anyhow.

fanatid commented 4 years ago

CI: Looks like not only we have problem with it: https://github.community/t5/GitHub-Actions/Github-action-stuck-at-queue/td-p/38003/page/6

holgerd77 commented 4 years ago

👍

fanatid commented 4 years ago

Published as v5.1.2.

holgerd77 commented 4 years ago

Ok, I re-added the browser tests I commented out before on the wallet library PR https://github.com/ethereumjs/ethereumjs-wallet/pull/121, if test-browser check is running through we also have a "real-life" confirmation that this is working. 😄

holgerd77 commented 4 years ago

Ok, can confirm, browser tests ran through.