fix: Buffer not using global in browser, closes #259

indutny / bn.js

BigNum in pure javascript

MIT License

1.19k stars 150 forks source link

fix: Buffer not using global in browser, closes #259 #260

Closed kyranjamie closed 3 years ago

kyranjamie commented 3 years ago

Closes issue #259

Redeclaring Buffer prohibits using a globally-defined polyfill.

fanatid commented 3 years ago

Thanks. Is it possible to test the new code somehow?

fanatid commented 3 years ago

ping @kyranjamie

kyranjamie commented 3 years ago

I had a look, but wasn't figure out how to test this. There are no tests are in place at present.

Also ran into issues coercing a mock window object, where linter rejects with Read-only global 'window' should not be modified.. Found no docs as to how to disable this check.

fanatid commented 3 years ago

Thank you.