search

indutny / elliptic

Fast Elliptic Curve Cryptography in plain javascript
1.7k stars 381 forks source link

Avoid circular dependency #180

Closed shrpne closed 5 years ago

shrpne commented 5 years ago

Here are changes from #157 rebased to master

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.05%) to 89.107% when pulling ab34e0f08994bcad9fa986899cd8d1ae4436d66e on shrpne:fix-circular into 523da1cf71ddcfd607fbdee1858bc2af47f0e700 on indutny:master.

lemoustachiste commented 5 years ago

I am having conflicts now between dependencies as some install 6.4.1 and the fix by @xg-wang is for 6.4.0. Could we merge this to regain sanity? Elliptic is a subdependency of my project and I don't have direct control over it.

Thanks a lot

shrpne commented 5 years ago

@lemoustachiste you can try to install required elliptic version as a dependency of your project and then run npm dedupe elliptic it should replace all elliptic version with your installed version

lemoustachiste commented 5 years ago

yes that's what I am doing now and it works fine. But it's a bit tedious.

shrpne commented 5 years ago

@indutny friendly reminder that PR is ready to be merged :)

indutny commented 5 years ago

Landed in dbe8bc6 and released in 6.5.0. Thank you, and sorry for delay!