search

indutny / elliptic

Fast Elliptic Curve Cryptography in plain javascript
1.7k stars 381 forks source link

Update bn.js to address Buffer deprecation #197

Closed exoego closed 4 years ago

exoego commented 5 years ago

Closes #196

exoego commented 5 years ago

Hmm, some tests failed due to this changes in bn.js. How should these tests be addressed? Does this indicated an issue in elliptic, or in bn.js ?

EDIT: I fixed the tests in elliptic https://github.com/indutny/elliptic/pull/197/commits/83ff21868eef21fcc101f9a99e2bb2985f087bd8.

fanatid commented 5 years ago

package-lock.json should not be added. There still no decision how this should be handled. See #191

exoego commented 5 years ago

@fanatid It seems that Travis complains unless package-lock.json included

fanatid commented 5 years ago

Oh, sorry. package-lock.json in this repo now, that's why Travis show error. On each dependency update package-lock.json should be updated too...

exoego commented 5 years ago

Ok, I will add package-lock.json back.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.006%) to 89.114% when pulling 1894eb94fc1ffaac6b793f66b67e7f217823b28d on exoego:buffer-deprecation into 71e4e8e2f5b8f0bdbfbe106c72cc9fbc746d3d60 on indutny:master.

exoego commented 5 years ago

Hello core developers, how should I proceed this and related PRs?

exoego commented 4 years ago

@fanatid Updated bn.js to 5.1.1 since newer version have been released while waiting review.

exoego commented 4 years ago

Closing as a duplicate, since a maintainer opened a same PR in #210