indutny / miller-rabin

27 stars 12 forks source link

Update bn.js #1

Closed guybedford closed 9 years ago

guybedford commented 9 years ago

See also:

If it doesn't make sense to update all of these, perhaps public-encrypt and browserify-rsa can be reverted to 0.15? I understand the upgrade paths will involve forks often, but it would be nice to minimize ecosystem forks of stable primary releases.

indutny commented 9 years ago

Landed in bb85f55. Btw, I thought that having ^ means that npm will update minor and patch versions automatically. Isn't it true?

guybedford commented 9 years ago

Thanks!

^ for 0.x.x versions means only auto-update the patch version. And for 0.0.x it is the same as a full lock. See https://github.com/npm/node-semver#caret-ranges-123-025-004.

indutny commented 9 years ago

Ah, I see. It should be 1.x.x to work this way...

indutny commented 9 years ago

Thanks!

guybedford commented 9 years ago

Awesome, thanks for the quick response!

andrey-p commented 9 years ago

Wouldn't it be a better idea to have bn.js as a regular dependency rather than a peerDependency? I was under the impression that it was built for plugin-type relationships: http://blog.nodejs.org/2013/02/07/peer-dependencies/

(I'm only writing this because this change somehow bubbled down the dependency chain and broke my browserify install - I assume it's causing problems for quite a few more people too.)