search

indutny / node-nat-upnp

NAT port mapping via UPnP
147 stars 59 forks source link

client: add support for 0-based indexed routers in getMappings #29

Closed carpie closed 8 years ago

carpie commented 8 years ago

This change makes getMappings start at 0 to support 0-based indexed routers. However, it will still check index 1 if index 0 fails to hopefully still support 1-based indexed routers. Addresses issue #28.

carpie commented 8 years ago

Sorry, my editor was set to 4. Updated and squashed.

indutny commented 8 years ago

No worries, thank you!

indutny commented 8 years ago

Released in 1.0.4 . Enjoy! 😉

carpie commented 8 years ago

Thanks! :)