search

indutny / node-nat-upnp

NAT port mapping via UPnP
147 stars 59 forks source link

netroute module creates incompatibility with node-webkit #6

Closed nickcmaynard closed 10 years ago

nickcmaynard commented 10 years ago

We're creating a node-webkit application and would like to use nat-upnp.

The netroute module required by nat-upnp uses C++ to achieve its aims, creating some specialist build requirements for node-webkit.

The hacked nw-gyp script currently can't handle netroute.

What approaches can we take to fix this? Should nat-upnp avoid use of a C++ module? Should netroute be updated to workaround the nw-gyp problem? Clearly nw-gyp should be fixed, but there are a number of nw-gyp issues open, so this may take some time.

indutny commented 10 years ago

Hm... why are all these classes under v8::internal:: namespace? Could you please gist a v8.h that is being included?

indutny commented 10 years ago

Also which v8 version does node-webkit use?

nickcmaynard commented 10 years ago

Sorry, I can't help with those queries - I'm afraid I don't really understand the underlying issues here. Certainly, the code that's using v8 appears to be netroute.cc.

indutny commented 10 years ago

And it is usually fine, as the addons are using v8 heavily :) I'll look into it.

indutny commented 10 years ago

Yeah, looks like node-webkit is using newer v8.

nickcmaynard commented 10 years ago

Thank you!

indutny commented 10 years ago

Please give a try to netroute@0.2.5, I hope it is all fixed now.

nickcmaynard commented 10 years ago

Fixed with https://github.com/indutny/node-netroute/commit/6432facdb2da794d8028b2225ea948a01a4ba523