Support Webpack 4 - Githubissues

indutny / webpack-common-shake

CommonJS Tree Shaker plugin for WebPack

918 stars 13 forks source link

Support Webpack 4 #26

Closed jkrems closed 6 years ago

jkrems commented 6 years ago

This is definitely a breaking change but I hope it'll be useful for yourself or other people who are trying to use this plugin with webpack 4.

plugin: Upgrade to webpack 4
plugin: Fix harmony import detection
lib: Resolve deprecation warnings

This PR was started by: git wf pr

jkrems commented 6 years ago

I also tested this branch against our internal asset pipeline and the old webpack 3 test case now passes with webpack 4.

indutny commented 6 years ago

Awesome patch!

@jkrems would you be interested in becoming a maintainer of this project?

jkrems commented 6 years ago

@indutny Sure! I'm not sure how much time I'd be able to spend on it on a regular basis but we'll be actively using it and I'm happy to help react to the issue tracker / address bugs and regressions / etc..

indutny commented 6 years ago

@jkrems thank you so much! I've added you to github collaborators. What is your npm id?

jkrems commented 6 years ago

Got the invite! My id on npm is jkrems.

indutny commented 6 years ago

Yay! Added you to npm owners too. Please consider enabling 2FA on npm, if you haven't already!

Thanks again!

jkrems commented 6 years ago

Let me check. Done!

jkrems commented 6 years ago

@indutny What's your preferred flow for landing changes? Other collaborator signs off, squash & merge, release via npm version <x> and push+publish?

indutny commented 6 years ago

@jkrems there're not that many collaborators at the moment, so green CI might be considered a sign-off. Otherwise, it is just as you said: squash, npm version xxx and push + publish.

jkrems commented 6 years ago

Got it. Will try to publish this change as a major bump.

jkrems commented 6 years ago

Published as v2.0.0