indygreg / apple-platform-rs

Rust crates supporting Apple platform development
595 stars 49 forks source link

Error: binary parsing error: Buffer is too short for 52 arches #170

Open a-zitzewitz opened 2 weeks ago

a-zitzewitz commented 2 weeks ago

I am trying to sign an application written in Java with the following command:

rcodesign sign --p12-file ~/rcodesign/hello2morrow.p12 --p12-password-file ~/rcodesign/password.txt Sonargraph.app

This is the output:

registering signing key automatically registered Apple CA certificate: Developer ID Certification Authority automatically registered Apple CA certificate: Apple Root CA using time-stamp protocol server http://timestamp.apple.com/ts01 automatically setting team ID from signing certificate: WJYWD3F88N signing Sonargraph.app in place signing bundle at Sonargraph.app signing bundle at Sonargraph.app into Sonargraph.app signing Mach-O file Contents/Eclipse/bin/ccspy creating cryptographic signature with certificate Developer ID Application: hello2morrow, Inc. (WJYWD3F88N) signing Mach-O file Contents/Eclipse/plugins/com.sun.jna_5.14.0.v20231211-1200/com/sun/jna/AltCallingConvention.class Error: binary parsing error: Buffer is too short for 52 arches

What can I do to fix that?

a-zitzewitz commented 2 weeks ago

When I add --exclude "*.class" it seems to work

indygreg commented 1 week ago

We're currently only reading the 4 byte header magic to determine if a file is a Mach-O. Clearly this is prone to false positives.

Sounds like we'll need to perform a more heavyweight validation to test if a file is a Mach-O.

a-zitzewitz commented 1 week ago

Well, with the exclude option it works. Thanks for a great piece of software that simplifies our life…

Best regards

Alexander von Zitzewitz

http://blog.hello2morrow.com

Book an online meeting with me:

https://calendly.com/hello2morrow

On Nov 9, 2024, at 5:01 PM, Gregory Szorc @.***> wrote:

We're currently only reading the 4 byte header magic to determine if a file is a Mach-O. Clearly this is prone to false positives.

Sounds like we'll need to perform a more heavyweight validation to test if a file is a Mach-O.

— Reply to this email directly, view it on GitHub https://github.com/indygreg/apple-platform-rs/issues/170#issuecomment-2466476170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC67B2HAZ4I4FUCGV5IOERDZ72A3BAVCNFSM6AAAAABRNUSUI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGQ3TMMJXGA. You are receiving this because you authored the thread.