search

indygreg / apple-platform-rs

Rust crates supporting Apple platform development
568 stars 40 forks source link

Export notary api. #60

Closed dvc94ch closed 1 year ago

dvc94ch commented 1 year ago

This change was dropped from my PR. Wanted to reopen to discuss it in more detail.

A consumer of the notarization api would have to add app-store-connect as a dependency and hope that the version matches the one required by apple-codesign. This is because the response types of the notary_api are part of the public api of the Notarizer. I think a crate should export all types in it's public api. An alternative would be to try to remove the types from the public api, by wrapping them with types in this crate that hide the inner type. But in this case I think that reexporting notary_api is the sensible thing to do. wdyt?

dvc94ch commented 1 year ago

Can you make a new release? That would be really helpful. Thanks!

indygreg commented 1 year ago

Can you make a new release? That would be really helpful. Thanks!

I released all the crates in this repo except for apple-bom, which still isn't ready to be published.