search

indygreg / cryptography-rs

A collection of Rust crates in the cryptography space
12 stars 17 forks source link

TimeStamped Data #7

Closed enri1196 closed 1 year ago

enri1196 commented 1 year ago

Thanks to your work i was able to serialize documents with time stamps as defined by rfc5544, hopefully you'll find this PR useful. The last missing piece would be verification, which i'm not too familiar with.

indygreg commented 1 year ago

Thanks for the contribution! I'm going to look at this now.

I'll likely split this up into different commits to make it easier for me to review. e.g. committing the new ASN.1 types first then look at the code that uses them. I'll preserve your authorship on the commits to reflect your contribution.

enri1196 commented 1 year ago

Thanks for coding this!

I'm going to commit changes to the x509-certificate crate since they look OK.

But the CMS crate changes need a bit of work.

Also, I'm not familiar with the new RFCs. Do you have examples of software producing messages using these new types? If possible, I'd like to commit files so we can validate parsing.

First of all thanks for taking a look at my MR, once I've some more time from work I'll try to implement all the suggestions above.

I'll see what I can do to get a file example, because I was trying to verify some files that I cannot freely upload and I wanted to implement that verification in Rust. Softwares that can verify these files should be Aruba Sign or Dike GoSign.