search

indygreg / python-build-standalone

Produce redistributable builds of Python
BSD 3-Clause "New" or "Revised" License
1.71k stars 107 forks source link

unix: fix CLFAGS typo in some scripts. #157

Closed chenxu2048 closed 1 year ago

chenxu2048 commented 1 year ago

We tried to build python with aarch64 and musl, but got failed in some packages.

These packages use CLFAGS while building and some substantial flags for musl-clang like --target=aarch64-linux-musl can not be read by configure scripts.

NOTE: fix may cause failed in some variants building.

indygreg commented 1 year ago

OK. We use the system libedit on macOS. So exposure here is to Linux.

The Rust validation code (which runs in CI) validates the ELF and Mach-O headers to ensure the advertised CPU type matches what is expected for the target triple. I spot checked that this was correctly inspecting all .o files, even though inside .a archives and that it was looking at libedit's .o files. It was.

So I think that means none of the distributions we have been`` shipping are impacted by this. i.e. it is only a bug for local cross-compile scenarios.