search

indygreg / python-build-standalone

Produce redistributable builds of Python
Mozilla Public License 2.0
1.97k stars 125 forks source link

WIP: Build with Openssl 3.0 on Linux and macOS #189

Closed Edward-Knight closed 1 year ago

Edward-Knight commented 1 year ago

I've been working on this on-and-off for some time, and got it mostly working. Builds for the mips and i686 architectures are still not working unfortunately.

indygreg commented 1 year ago

Oh no, I don't think you realized that I had already started much of this work. Check out the ci-test branch in this repo.

On a somewhat reassuring note, the similarities in the diff are striking. When I first looked at this PR I thought maybe you based it off the commits I wrote last weekend!

I'm sorry you incurred this redundant work. That's on me for not publishing my work to a PR. (I don't like GitHub's PR workflows and avoid them when possible.)

Edward-Knight commented 1 year ago

No worries, I was slowly working on my fork for a while but could have communicated that better. I'm happy to see the work done and merged :)

Glad to hear we had a similar approach, call it a code review by proxy!

I also made a couple of minor fixes while working on this, I'll cherry-pick them across to another MR and close this one