search

indygreg / python-build-standalone

Produce redistributable builds of Python
BSD 3-Clause "New" or "Revised" License
1.71k stars 107 forks source link

Remove LTO-only builds when PGO+LTO exists #223

Closed charliermarsh closed 3 months ago

charliermarsh commented 4 months ago

Summary

This PR removes lto builds for cases in which pgo+lto exists, which looked like a good first task to familiarize myself with the project structure.

Closes https://github.com/indygreg/python-build-standalone/issues/220.

charliermarsh commented 4 months ago

Unclear on the best way to test this (if any?). My methodology was to grep for pgo+lto, then work backwards to identify the sites at which lto should be removed.

indygreg commented 4 months ago

Actually, I cherry-picked the hopeful CI fix commit to your branch. Let's see if CI works now.

Feel free to rebase the branch at your leisure. The latest HEAD commit should disappear.

charliermarsh commented 4 months ago

@indygreg -- Thanks for cherry-picking. Want me to rebase or will you squash-merge either way?

indygreg commented 4 months ago

@indygreg -- Thanks for cherry-picking. Want me to rebase or will you squash-merge either way?

Please rebase. (I could do this myself but I try not to force push to other people's branches as a matter of courtesy since Git doesn't handle force pushes very well!)

I also try to have a linear, merge-free history in the repo. Up to this point usually I've been cherry picking commits locally and amending commit messages in flight. It isn't very GitHub-y. But I don't need to be a stickler for this preference going forward.