search

indygreg / python-build-standalone

Produce redistributable builds of Python
BSD 3-Clause "New" or "Revised" License
1.71k stars 107 forks source link

Remove `shared-` prefix from Windows profiles #241

Closed charliermarsh closed 3 months ago

charliermarsh commented 3 months ago

Summary

In https://github.com/indygreg/python-build-standalone/pull/234, we removed the Windows static builds from python-build-standalone. As such, the shared- prefix (in, e.g., shared-pgo) is no longer necessary, since there's no need to differentiate the shared builds from the static builds.

This PR removes the shared- prefix, but continues to publish under both profiles to allow for a transition period for consumers of the shared- builds.

Closes https://github.com/indygreg/python-build-standalone/issues/237.

Test Plan

Downloaded one of the release artifacts locally:

~/Downloads on  main [!+?] via 🐍 v3.12.0
❯ cd cpython-3.8-vcvars64.bat-pgo
~/Downloads/cpython-3.8-vcvars64.bat-pgo on  main [!+?]
❯ ls
cpython-3.8.18-x86_64-pc-windows-msvc-pgo-20240330T1749.tar.zst
cpython-3.8.18-x86_64-pc-windows-msvc-shared-pgo-20240330T1749.tar.zst
~/Downloads/cpython-3.8-vcvars64.bat-pgo on  main [!+?]
❯ shasum cpython-3.8.18-x86_64-pc-windows-msvc-*
718227dbe11dcdf74283952a6b01a769cd5e2919  cpython-3.8.18-x86_64-pc-windows-msvc-pgo-20240330T1749.tar.zst
718227dbe11dcdf74283952a6b01a769cd5e2919  cpython-3.8.18-x86_64-pc-windows-msvc-shared-pgo-20240330T1749.tar.zst
indygreg commented 3 months ago

I manually cancelled actions for Linux and macOS due to xz download bustage. Rebase on main to get working CI.